#4327: Refactor and extend root systems plots
----------------------------------------------------+-----------------------
Reporter: nthiery | Owner: mhansen
Type: enhancement | Status:
needs_review
Priority: minor | Milestone: sage-5.10
Component: combinatorics | Resolution:
Keywords: | Work issues:
Report Upstream: N/A | Reviewers: Nicolas
M. Thiéry, Nicolas Borie, Travis Scrimshaw
Authors: Nicolas Borie, Nicolas M. Thiéry | Merged in:
Dependencies: #14175, #14176, #14177, #2023 | Stopgaps:
----------------------------------------------------+-----------------------
Changes (by nthiery):
* status: needs_work => needs_review
* work_issues: minor long test failure =>
Comment:
Hi Travis,
The updated patch fixes the doc so that later on doctests won't be
ignored, and update the number of ignored doctests in the mean time.
All long tests passed.
Here is the metadiff:
{{{
diff --git a/trac_4327-root_system_plot_refactor-nt.patch b/trac_4327
-root_system_plot_refactor-nt.patch
--- a/trac_4327-root_system_plot_refactor-nt.patch
+++ b/trac_4327-root_system_plot_refactor-nt.patch
@@ -1,5 +1,5 @@
# HG changeset patch
-# Parent aa718acb2dbac8faab463c994aa7f4052a546363
+# Parent 89d0e0f941ae79ca2d8dd83d3ac6d20a4b82382a
#4327: Refactor and extend root systems plots
diff --git a/doc/en/reference/combinat/root_systems.rst
b/doc/en/reference/combinat/root_systems.rst
@@ -2569,7 +2569,7 @@ diff --git a/sage/combinat/root_system/t
import ambient_space
class AmbientSpace(ambient_space.AmbientSpace):
-@@ -135,13 +136,38 @@ class AmbientSpace(ambient_space.Ambient
+@@ -135,13 +136,36 @@ class AmbientSpace(ambient_space.Ambient
given, returns (k, ... ,k), the k-th power of the
determinant.
@@ -2582,14 +2582,8 @@ diff --git a/sage/combinat/root_system/t
"""
return self.sum(self.monomial(j)*k for j in range(self.n))
-+ """
-+ Use barycentric projection by default
-+
-+ .. SEEALSO::
-+
-+ -
:meth:`sage.combinat.root_system.root_lattice_realizations.RootLatticeRealizations._plot_projection`
-+
-+ EXAMPLES::
++ __doc__ += """
++ By default, this ambient space uses the barycentric projection for
plotting::
+
+ sage: L = RootSystem(["A",2]).ambient_space()
+ sage: e = L.basis()
@@ -2604,6 +2598,10 @@ diff --git a/sage/combinat/root_system/t
+ (2, 2, 3, 0)
+ sage: L._plot_projection(l)
+ (0, -1121/1189, 7/3)
++
++ .. SEEALSO::
++
++ -
:meth:`sage.combinat.root_system.root_lattice_realizations.RootLatticeRealizations.ParentMethods._plot_projection`
+ """
+ _plot_projection =
RootLatticeRealizations.ParentMethods.__dict__['_plot_projection_barycentric']
@@ -2621,18 +2619,12 @@ diff --git a/sage/combinat/root_system/t
class AmbientSpace(ambient_space.AmbientSpace):
"""
EXAMPLES::
-@@ -82,6 +82,32 @@ class AmbientSpace(ambient_space.Ambient
+@@ -82,6 +82,30 @@ class AmbientSpace(ambient_space.Ambient
return Family({ 1: self([1,0,-1]),
2: self([2,-1,-1])})
-+ """
-+ Use barycentric projection by default
-+
-+ .. SEEALSO::
-+
-+ -
:meth:`sage.combinat.root_system.root_lattice_realizations.RootLatticeRealizations._plot_projection`
-+
-+ EXAMPLES::
++ __doc__ += """
++ By default, this ambient space uses the barycentric projection for
plotting::
+
+ sage: L = RootSystem(["G",2]).ambient_space()
+ sage: e = L.basis()
@@ -2647,6 +2639,10 @@ diff --git a/sage/combinat/root_system/t
+ (2, 2, 3, 0)
+ sage: L._plot_projection(l)
+ (0, -1121/1189, 7/3)
++
++ .. SEEALSO::
++
++ -
:meth:`sage.combinat.root_system.root_lattice_realizations.RootLatticeRealizations.ParentMethods._plot_projection`
+ """
+ _plot_projection =
RootLatticeRealizations.ParentMethods.__dict__['_plot_projection_barycentric']
+
@@ -3011,3 +3007,15 @@ diff --git a/sage/combinat/root_system/w
- G.axes(False)
- return G
-
+diff --git a/sage/doctest/sources.py b/sage/doctest/sources.py
+--- a/sage/doctest/sources.py
++++ b/sage/doctest/sources.py
+@@ -675,6 +675,8 @@ class FileDocTestSource(DocTestSource):
+ There are 18 tests in sage/combinat/partition.py that are
not being run
+ There are 12 tests in sage/combinat/tableau.py that are not
being run
+ There are 15 tests in
sage/combinat/root_system/cartan_type.py that are not being run
++ There are 8 tests in sage/combinat/root_system/type_A.py
that are not being run
++ There are 8 tests in sage/combinat/root_system/type_G.py
that are not being run
+ There are 3 unexpected tests being run in
sage/doctest/parsing.py
+ There are 1 unexpected tests being run in
sage/doctest/reporting.py
+ There are 9 tests in sage/graphs/graph_plot.py that are not
being run
}}}
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/4327#comment:21>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
