#4327: Refactor and extend root systems plots
----------------------------------------------------+-----------------------
Reporter: nthiery | Owner: mhansen
Type: enhancement | Status:
needs_work
Priority: minor | Milestone: sage-5.10
Component: combinatorics | Resolution:
Keywords: | Work issues:
Report Upstream: N/A | Reviewers: Nicolas
M. Thiéry, Nicolas Borie, Travis Scrimshaw
Authors: Nicolas Borie, Nicolas M. Thiéry | Merged in:
Dependencies: #14175, #14176, #14177, #2023 | Stopgaps:
----------------------------------------------------+-----------------------
Comment (by nthiery):
Replying to [comment:23 jdemeyer]:
> The PDF documentation doesn't build:
> {{{
> ! Package inputenc Error: Keyboard character used is undefined
> (inputenc) in inputencoding `utf8x'.
> ...
> }}}
Ah shoot, sorry about that. The docstrings for this method was missing its
starting 'r', and which caused a {{{\a}}} in it to be misinterpreted as a
non UTF-8 character.
The newly updated patch fixes this. While I was at it, it fixes half a
dozen other missing 'r' in other methods introduced by this patch.
Since the change is trivial, I am allowing myself to put it back to
positive review.
For the record, here is the diff between the two patches:
{{{
diff --git a/trac_4327-root_system_plot_refactor-nt.patch b/trac_4327
-root_system_plot_refactor-nt.patch
--- a/trac_4327-root_system_plot_refactor-nt.patch
+++ b/trac_4327-root_system_plot_refactor-nt.patch
@@ -1,5 +1,5 @@
# HG changeset patch
-# Parent 89d0e0f941ae79ca2d8dd83d3ac6d20a4b82382a
+# Parent 75e26170e32bcbb5f78e1784a1df985ecb71e1db
#4327: Refactor and extend root systems plots
diff --git a/doc/en/reference/combinat/root_systems.rst
b/doc/en/reference/combinat/root_systems.rst
@@ -631,7 +631,7 @@ new file mode 100644
+lazy_import("sage.combinat.root_system.root_lattice_realizations",
"RootLatticeRealizations")
+
+class PlotOptions:
-+ """
++ r"""
+ A class for plotting options for root lattice realizations.
+
+ .. SEEALSO::
@@ -740,7 +740,7 @@ new file mode 100644
+
+ @cached_method
+ def in_bounding_box(self, x):
-+ """
++ r"""
+ Return whether ``x`` is in the bounding box.
+
+ INPUT:
@@ -763,7 +763,7 @@ new file mode 100644
+ return self.bounding_box.contains(self.projection(x))
+
+ def text(self, label, position):
-+ """
++ r"""
+ Return text widget with label ``label`` at position ``position``
+
+ INPUT:
@@ -851,7 +851,7 @@ new file mode 100644
+ return self._color("other")
+
+ def projection(self, v):
-+ """
++ r"""
+ Return the projection of ``v``.
+
+ INPUT:
@@ -880,7 +880,7 @@ new file mode 100644
+ return v
+
+ def intersection_at_level_1(self, x):
-+ """
++ r"""
+ Return ``x`` scaled at the appropriate level, if level is set;
+ otherwise return ``x``.
+
@@ -912,7 +912,7 @@ new file mode 100644
+ return x
+
+ def empty(self, *args):
-+ """
++ r"""
+ Return an empty plot.
+
+ EXAMPLES::
@@ -1255,7 +1255,7 @@ new file mode 100644
+
+@cached_function
+def barycentric_projection_matrix(n, angle=0):
-+ """
++ r"""
+ Returns a family of `n+1` vectors evenly spaced in a real vector
space of dimension `n`
+
+ Those vectors are of norm `1`, the scalar product between any two
@@ -2339,7 +2339,7 @@ diff --git a/sage/combinat/root_system/r
+
+
+ def plot_bounding_box(self, **options):
-+ """
++ r"""
+ Plot the bounding box.
+
+ INPUT:
}}}
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/4327#comment:24>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
