#11935: Make parent/element classes independent of base rings
----------------------------------------------------------+-----------------
Reporter: SimonKing | Owner:
Type: enhancement | Status:
needs_review
Priority: major | Milestone:
sage-5.10
Component: categories | Resolution:
Keywords: parent class, element class, category | Work issues:
Report Upstream: N/A | Reviewers:
Authors: Simon King | Merged in:
Dependencies: #9138, #11900, #11943, #12875, #12877 | Stopgaps:
----------------------------------------------------------+-----------------
Comment (by nthiery):
Hi Simon,
I just went through the history of this ticket. At this point, I feel
it's a reasonable choice to have the parent/element classe of a
category over base depend only on the base.
The patch I just uploaded includes:
- The latest version of
trac11935_weak_pickling_by_construction_rel11943-nt.patch in the
Sage-Combinat queue (which was that from trac + some rebase + little
improvements)
- trac11935_share_on_base_category.patch
- Doctests for the _make_named_class_key methods that were missing it
- Some doc minor improvements
With this patch applied on top of #12876, all long test passed on my
machine, and I still get the desired speedup for our standard elliptic
curve benchmark:
{{{
sage: %time L = EllipticCurve('960d1').prove_BSD()
CPU times: user 2.98 s, sys: 0.08 s, total: 3.06 s
Wall time: 3.17 s
}}}
{{{
sage: %time L = EllipticCurve('960d1').prove_BSD()
CPU times: user 2.06 s, sys: 0.04 s, total: 2.10 s
Wall time: 2.20 s
}}}
From my point of view, it's good to go. To completely finish the
review I just need someone to proofread the doctests for the
_make_named_class_key methods. And you may want to glance through the
patch.
Note: I have decided to fold the patches together because anyway
trac11935_weak_pickling_by_construction_rel11943-nt.patch was changed
in the mean time. Also, since this has been a long time, I guess its
easier to glance through and see the big picture. And it's not so long
anyway.
Cheers,
Nicolas
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11935#comment:82>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
