#11935: Make parent/element classes independent of base rings
----------------------------------------------------------+-----------------
Reporter: SimonKing | Owner:
Type: enhancement | Status:
needs_work
Priority: major | Milestone:
sage-5.10
Component: categories | Resolution:
Keywords: parent class, element class, category | Work issues:
Report Upstream: N/A | Reviewers:
Nicolas Thiery, Travis Scrimshaw
Authors: Simon King | Merged in:
Dependencies: #9138, #11900, #11943, #12875, #12877 | Stopgaps:
----------------------------------------------------------+-----------------
Comment (by tscrim):
Hey Simon,
Hmmm... it works for me on `5.10.beta3` with both patches applied.
Although I'm using the version of Nicolas' patch in the combinat queue,
but there are no real differences between the two patches:
{{{
diff trac11935_weak_pickling_by_construction-nt.patch ~/Downloads
/trac11935_weak_pickling_by_construction-nt.patch
4,5c4,5
< # Node ID 3045fe70aaf8fb0c0d9d3551944317ee0764c7da
< # Parent f5ad6657cff1a065b4192e84a96fca0bc597c2c7
---
> # Node ID 0e23d0ca3d0bb47caa234d9d1890f7c603f3ddbd
> # Parent f5ad6657cff1a065b4192e84a96fca0bc597c2c7
}}}
I don't quite understand the new patchbot logs yet, so but have you tried
with both patches applied Simon (although I'd be somewhat surprised if my
review patch unintentionally fixed something).
Also I didn't look at the patch functionality, just the docstrings/tests
since this is what Nicolas stated as needing to be reviewed.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11935#comment:89>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
