#7477: Matroids
----------------------------------------------------+-----------------------
Reporter: ncohen | Owner: jkantor
Type: enhancement | Status:
needs_review
Priority: major | Milestone: sage-5.10
Component: combinatorics | Resolution:
Keywords: | Work issues:
Report Upstream: N/A | Reviewers:
Authors: Stefan van Zwam, Rudi Pendavingh | Merged in:
Dependencies: | Stopgaps:
----------------------------------------------------+-----------------------
Changes (by Stefan):
* status: needs_work => needs_review
Comment:
I just uploaded a new version of the patch. I tested it against
5.10.beta4, I hope it didn't break on 5.10.beta5...
Items fixed:
* Fixed multiline doctests to have ....:
Responding to darij:
* Improved documentation of cdef methods (especially doubly-underscored
ones)
* Corrected _with_coloop docstring
* Corrected typos
Responding to rbeezer:
* Fixed (2)
* Fixed EXAMPLES indentation (3)
* Got rid of MatroidError, made error messages lower case. Did not change
content of messages, leaving it for future improvements (4)
* Fixed the documentation (5)
Responding to vbraun (some comments are replies to issues from sage-
devel):
* I'm happy to move the bitset enhancements into the rest of Sage (I think
you're right that they belong there), but I'd like to wait until after
this patch has been accepted. It just keeps it less of a moving target,
and reduces the risk of having to rebase.
* Fixed/removed some import statements that got broken (this caused the
segfaults)
* Made the lean_matrix interfaces agree with Sage's Matrices to the
largest extent (see comments near top of linear_matroid.pyx).
The LinearMatroid class only uses the trivial nonstandard ``is_nonzero``
method now. The subclasses BinaryMatroid, TernaryMatroid,
QuaternaryMatroid, RegularMatroid use a few more methods that have no Sage
Matrix equivalent, but all are flagged in the code, and it should be
possible to replace them. One last remark: the lean_matrix.pyx code is
ONLY used as internal data structure, we don't expose any of it to the
user (unless they try really hard). Everything the user sees is a normal
Sage matrix.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/7477#comment:38>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
