#5778: [with patch; with positive review but serious reservations] More p-adic
doctests
---------------------------+------------------------------------------------
 Reporter:  roed           |       Owner:  was       
     Type:  defect         |      Status:  new       
 Priority:  major          |   Milestone:  sage-3.4.2
Component:  number theory  |    Keywords:  doctests  
---------------------------+------------------------------------------------

Comment(by cremona):

 The patch applies and tests pass.

 As I cannot view the patch (it is too big) I don't actually know what has
 changed.  Apparently the files have been restified, but the only way to
 test that would be to add them to the reference manual and try building.
 I started with factory.py as that seemed pretty important.  I found that
 the file while partially restified on a superficial level was completely
 broken as far as actually processing it is concerned.  I started
 correcting it and got to line 430, but it is 2200 lines long and so will
 take a lot longer.

 I suggest that this patch goes in since it is a step in the right
 direction;  but I don't promise to even get to the end of properly getting
 the docs for factory.py into the manual, let alone any of the rest (ha ha
 ) of it.

 On the positive side I not the very comprhjensive explanation of the
 p-adic code in a separate tutorial file which is in the reference manual;
 but I think that we do need the individual files (of which there are a
 large number) in there too.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/5778#comment:13>
Sage <http://sagemath.org/>
Sage - Open Source Mathematical Software: Building the Car Instead of 
Reinventing the Wheel

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to 
[email protected]
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to