#14402: Implement tensor product of infinite crystals
-----------------------------------------------------+----------------------
Reporter: tscrim | Owner:
sage-combinat
Type: enhancement | Status:
needs_review
Priority: major | Milestone:
sage-5.10
Component: combinatorics | Resolution:
Keywords: infinite crystals, tensor product | Work issues:
Report Upstream: N/A | Reviewers:
Authors: Ben Salisbury, Travis Scrimshaw | Merged in:
Dependencies: #14454 #14266 | Stopgaps:
-----------------------------------------------------+----------------------
Comment (by aschilling):
Hi Travis,
I left a review patch on the sage-combinat queue. In particular, I think
the formula for \phi_i in terms of the a_i was not quite right in your
patch, so I tried to correct it (it is now very simple, namely
max(\lambda_i+a_i(k))). Please check that you agree! I also changed the
code accordingly. The tests still pass. Since the change did not seem to
make a difference for the tests, it might be a good idea to put some
stronger tests in that check all possible cases for the \epsilon_i and
\phi_i, so that you are sure that the code is doing what it is supposed to
be doing (perhaps run some exhaustive tests for regular crystals in some
example against the alternative implementation).
If you are happy with the review patch you can fold it in and make the
above changes as well.
Thanks!
Anne
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/14402#comment:5>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
