#7477: Matroids
----------------------------------------------------+-----------------------
Reporter: ncohen | Owner: jkantor
Type: enhancement | Status:
needs_review
Priority: major | Milestone: sage-5.10
Component: combinatorics | Resolution:
Keywords: | Work issues:
Report Upstream: N/A | Reviewers:
Authors: Stefan van Zwam, Rudi Pendavingh | Merged in:
Dependencies: #14669 | Stopgaps:
----------------------------------------------------+-----------------------
Comment (by rbeezer):
Thanks, Michael.
Comments interspersed.
Replying to [comment:56 yomcat]:
> You haven't got to catalog.py yet (it's horrible for this), but is there
a general guideline on characters per line?
"Python Enhancemant Proposal 8", aka PEP 8,
http://www.python.org/dev/peps/pep-0008/
says "max 79 characters"
> >
> > Code: "If that fails, we simply use a list `[0..m-1]`"
> > The single backticks are giving TeX, this should definitely be code,
hence two backticks
> > Probably the (i,j) preceding is similar, though we could debate if
that is math or code.
>
> There were lots like this, so I left them as they are, as that's a
debate I don't really want to have.
Yes, no need to debate, but `[0..m-1]` is definitely code and should
definitely be in double backticks. I don't want to debate either - but it
is often extremely clear if you have code or math, and these should be
formatted right.
> >
> > f-vector() documentation:
> > Has a list with just one item for output. Probably does not need
to be a list. Ditto for flats(). I'm seeing more like this. I'm
inclined to just write a paragraph, unless returning a pair, triple, or
...
>
> I'm confused. f_vector() returns a list [f_0, ..., f_r] where f_i is the
number of flats of rank i, and r the rank of the matroid. That's got more
than one thing in it. And flats() returns a SetSystem, not a list, and
there's normally a lot more than one flat at a given rank.
My mistake, not clear. The OUTPUT section documents a single output of
trhe function and is formatted as a list with one item. I don't think a
list is necessary. INPUT will often have many items, and a list is
natural. There are lots of OUTPUT done as a one-item list. `f_vector()`
was just the first one I saw.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/7477#comment:57>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
