#12949: Better congruence testing for odd arithmetic subgroups
----------------------------------+-----------------------------------------
       Reporter:  davidloeffler   |         Owner:  craigcitro                  
   
           Type:  enhancement     |        Status:  needs_work                  
   
       Priority:  major           |     Milestone:  sage-5.11                   
   
      Component:  modular forms   |    Resolution:                              
   
       Keywords:                  |   Work issues:  bring back old code + minor 
doc
Report Upstream:  N/A             |     Reviewers:  Vincent Delecroix           
   
        Authors:  David Loeffler  |     Merged in:                              
   
   Dependencies:                  |      Stopgaps:                              
   
----------------------------------+-----------------------------------------
Changes (by vdelecroix):

  * status:  needs_review => needs_work
  * reviewer:  => Vincent Delecroix
  * work_issues:  => bring back old code + minor doc
  * milestone:  sage-5.10 => sage-5.11


Comment:

 I would prefer to keep both implementations (naive one vs checking
 relations with default to the latter one of course ;-). Then you may add a
 dedicated test comparing the results in `sage.modular.arithgroup.tests`.
 Otherwise the new implementation is well documented and everything works.

 Is your result available to read ? A dissertation is a legitimate
 reference, but one may want to read it.

 Why did you remove the reference of the article of Alexey G. Gorinov ? I
 do not claim that it is not a good idea but just that it was not the
 purpose of the ticket.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12949#comment:4>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to