#12949: Better congruence testing for odd arithmetic subgroups
----------------------------------+-----------------------------------------
       Reporter:  davidloeffler   |         Owner:  craigcitro       
           Type:  enhancement     |        Status:  needs_info       
       Priority:  major           |     Milestone:  sage-5.11        
      Component:  modular forms   |    Resolution:                   
       Keywords:                  |   Work issues:  ref issue + test 
Report Upstream:  N/A             |     Reviewers:  Vincent Delecroix
        Authors:  David Loeffler  |     Merged in:                   
   Dependencies:                  |      Stopgaps:                   
----------------------------------+-----------------------------------------
Changes (by vdelecroix):

  * work_issues:  bring back old code + minor doc => ref issue + test


Comment:

 Hi,

 Replying to [comment:5 davidloeffler]:
 > - I didn't remove the reference to Gorinov. I just moved it a little
 higher in the list so the references were listed in alphabetical order.

 My mistake.

 > - Hamilton's dissertation isn't available publicly anywhere, sadly;
 Warwick doesn't maintain an archive of MMath dissertations, although it
 does for MSc and PhD degrees. If you want to check the result, I have a
 copy I can send to you personally, if you like.

 I would appreciate a copy but this is not the point. If you mention the
 Math dissertation as a reference for the algorithm it should be available
 for anyone. What about arXiv ?

 > - I'm not quite sure what you're suggesting re keeping both algorithms.
 At the moment we have one (fast) algorithm for even subgroups only, and
 another (much slower) algorithm for odd subgroups. It seems silly to
 distinguish needlessly between even/odd -- would you be happier with a
 setup where we have both algorithms available for both types of subgroups
 (with the fast one the default, of course)?

 You are right. It would be better to keep the fast algorithm only and to
 implement the naive test within the `Test` class and check that the
 answers coincide.

 Best
 Vincent

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12949#comment:6>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to