#14668: Move functions from sage.matroids.bitset_tools to sage.misc
----------------------------------------------------+-----------------------
Reporter: Stefan | Owner: jason
Type: task | Status:
needs_review
Priority: minor | Milestone: sage-5.11
Component: misc | Resolution:
Keywords: | Work issues:
Report Upstream: N/A | Reviewers:
Authors: Rudi Pendavingh, Stefan van Zwam | Merged in:
Dependencies: | Stopgaps:
----------------------------------------------------+-----------------------
Comment (by ncohen):
Hellooooooooooooooo !!
Just a couple of comments :
* I thought at first that your `bitset_rev_lex_cmp` function was wrong,
and I noticed later that I had read "reverse lexicographic order" as "co-
lex order" (i.e. the lexicographic order on words when you read them from
right to left instead). Turns out that this "reverse lexicographic order"
can be obtained by adding a "-" to a call to the previous function.
I personally think that risking this confusion is not worth saving a `-`
in a source code, and that this '-' is not worth the space it takes to
store the code of this function in bitset.pxi either. Well, that's just my
advice, I don't mind much, I just say it aloud, do as you wish.
I also did not understand from its docstring what `bitset_morph` does, and
so I read the code. First, I think that "function" would be better than
"morphism" in this context. And as this actually computes the image of a
bitset by a function, renaming it to `bitset_image` or
`bitset_function_image` would make sense to me... What do you think ?
Anyway, have fuuuuuuuuuuuuuuuuuuuuuuuuuuuunnn !!!
Nathann
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/14668#comment:4>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
