#14655: Dynkin diagrams does not copy like digraph
---------------------------------------+------------------------------------
Reporter: tscrim | Owner: sage-combinat
Type: defect | Status: needs_work
Priority: major | Milestone: sage-5.10
Component: combinatorics | Resolution:
Keywords: dynkin diagram copy | Work issues:
Report Upstream: N/A | Reviewers: mshimo
Authors: Travis Scrimshaw | Merged in:
Dependencies: | Stopgaps:
---------------------------------------+------------------------------------
Changes (by mshimo):
* status: needs_review => needs_work
* reviewer: => mshimo
Comment:
Thanks, Travis, for fixing this. A few small things to deal with:
Please fix the docstring for :func:`DynkinDiagram`: the real issue for the
Cartan matrix convention
is transposing or not; in everyone's conventions the arrow points from a
*longer* root to a *shorter* one.
I ran the following tests and got some errors.
{{{
sage: d = DynkinDiagram(['A',3,1])
sage: TestSuite(d).run()
Failure in _test_not_implemented_methods:
Traceback (click to the left of this block for traceback)
...
The following tests failed: _test_not_implemented_methods
}}}
I'm not sure I understand why, but :class:`DynkinDiagram_class` inherits
from
:class:`CartanType_abstract` and therefore is obligated to supply its
abstract methods.
It appears not to fulfill its promise for :meth:`is_finite`,
:meth:`is_affine`, and :meth:`is_irreducible`.
Otherwise it looks great!
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/14655#comment:3>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
