#12289: pass algorithm argument to custom numeric evalution methods
-------------------------------------------------+--------------------------
Reporter: burcin | Owner: burcin
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-5.11
Component: symbolics | Resolution:
Keywords: pynac sd35.5 sd40.5 sd48 | Work issues: doctests,
documentation
Report Upstream: N/A | Reviewers: Karl-Dieter
Crisman, Doug S. MacNeil, Benjamin Jones
Authors: Burcin Erocal, Benjamin Jones | Merged in:
Dependencies: #13933, #4102 | Stopgaps:
-------------------------------------------------+--------------------------
Comment (by kcrisman):
> So that we don't forget to fix it later:
> {{{
> sage: erf(1).n(algorithm='foo')
> 0.842700792949715
> sage: erf(0)
> 0
> sage: parent(erf(0))
> Integer Ring
> sage: erf(0).n(algorithm='foo')
>
---------------------------------------------------------------------------
> TypeError Traceback (most recent call
last)
>
> /Users/mcneil/sagedev/sage-5.1.beta0b/sage-5.1.beta0/devel/sage-
hack2/sage/<ipython console> in <module>()
>
> /Users/mcneil/sagedev/sage-5.1.beta0b/sage-5.1.beta0/local/lib/python2.7
/site-packages/sage/structure/element.so in
sage.structure.element.Element.numerical_approx
(sage/structure/element.c:4988)()
>
> TypeError: numerical_approx() got an unexpected keyword argument
'algorithm'
> }}}
This is now #14778. Shouldn't impact this being merged.
By which to say, this passes all tests. The most recent fixes are fine.
Burcin, what would need to be reviewed still?
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12289#comment:24>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.
