#12949: Better congruence testing for odd arithmetic subgroups
----------------------------------+-----------------------------------------
Reporter: davidloeffler | Owner: craigcitro
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-5.11
Component: modular forms | Resolution:
Keywords: | Work issues:
Report Upstream: N/A | Reviewers: Vincent Delecroix
Authors: David Loeffler | Merged in:
Dependencies: | Stopgaps:
----------------------------------+-----------------------------------------
Comment (by vdelecroix):
Great! I am really happy that it was possible to put it on arxiv.
Everything looks fine except for the tests: `sage -t` on
sage.modular.arithgroup.tests was around 10sec and is now around Infinity.
When testing the congruence try to set index_max to a much smaller value.
You should also add some `# long time` wherever appropriate.
I also notice that
* the Test class should be clean up (there is no reason to use `print`
and there should be more occurences of tests inside the documentation)
* there is a broken link in the documentation (see
[https://groups.google.com/forum/#!topic/sage-devel/bnHspWvX3D4 this sage-
devel thread])
... but this ticket has nothing to do with it ;-)
Best,
Vincent
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12949#comment:11>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.
