#14826: Newton polygons
-----------------------------------+----------------------------------------
Reporter: caruso | Owner: roed
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-5.12
Component: padics | Resolution:
Keywords: Newton polygons | Work issues:
Report Upstream: N/A | Reviewers:
Authors: | Merged in:
Dependencies: | Stopgaps:
-----------------------------------+----------------------------------------
Comment (by vbraun):
That is of course not the same Newton polygon as
{{{
sage: R.<x,y> = QQ[]
sage: (1+x+y).newton_polytope()
A 2-dimensional polyhedron in ZZ^2 defined as the convex hull of 3
vertices
}}}
There might be a better place that does not require another global name,
maybe as method of local fields? At the very least the `NewtonPolygon`
docstring should make an effort to disambiguate.
A less scary way than `_normalize()` to compute the hull is to use some of
Sage's existing polyhedral computation facilities:
{{{
sage: hull = Polyhedron([(0,0), (1,1), (2,-1), (3,0)], rays=[(0,1)])
sage: hull.vertices()
(A vertex at (0, 0), A vertex at (3, 0), A vertex at (2, -1))
}}}
Docstrings frequently need `INPUT` / `OUTPUT`, see the sage developer
manual
PEP 8 spacing, e.g.
{{{
def __le__(self,other): # no
def __le__(self, other): # yes
}}}
* `ParentNewtonPolygon.__repr__` should be `_repr_`
* `NewtonPolygon_lastslope._repr_` docstring has unused import
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/14826#comment:2>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.
