#14471: Category refinement sometimes changes the hash of parents
--------------------------------+-------------------------------------------
Reporter: vbraun | Owner: rlm
Type: defect | Status: needs_review
Priority: critical | Milestone: sage-5.11
Component: memleak | Resolution:
Keywords: | Work issues:
Report Upstream: N/A | Reviewers: Simon King
Authors: Volker Braun | Merged in:
Dependencies: | Stopgaps:
--------------------------------+-------------------------------------------
Changes (by SimonKing):
* reviewer: => Simon King
Comment:
All tests pass (based on sage-5.11.b3). I think the patch solves the
problem in a clean way.
I think one should add a new test to `_refine_category`, demonstrating
that the class is ''not'' changed, if its hash depends on it. I plan to
add this in a review patch.
One might argue that any new class (such as `DebugOptions_class`) requires
new doctests. But it is just a means to store certain attributes, hence, I
think doctests will not be needed in this case.
Unfortunately the patchbot has not finished testing yet. But unless there
is a clear regression in startup time, I'll give it a positive review (as
soon as I have posted my review patch).
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/14471#comment:29>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.
