#14471: Category refinement sometimes changes the hash of parents
--------------------------------+-------------------------------------------
Reporter: vbraun | Owner: rlm
Type: defect | Status: positive_review
Priority: critical | Milestone: sage-5.11
Component: memleak | Resolution:
Keywords: | Work issues:
Report Upstream: N/A | Reviewers: Simon King
Authors: Volker Braun | Merged in:
Dependencies: | Stopgaps:
--------------------------------+-------------------------------------------
Changes (by SimonKing):
* status: needs_review => positive_review
Old description:
> Some objects with dynamical classes use `hash(self.__class__)`. Since
> this is not an invariant of dynamical classes bad things will happen.
>
> One such instance is that, under some circumstances, a
> !WeakValueDictionary remove callback is being called but cannot find the
> object in the dictionary since the hash changed.
>
> Apply [attachment:trac_14471_dynamic_class_hash.patch]
New description:
Some objects with dynamical classes use `hash(self.__class__)`. Since this
is not an invariant of dynamical classes bad things will happen.
One such instance is that, under some circumstances, a
!WeakValueDictionary remove callback is being called but cannot find the
object in the dictionary since the hash changed.
__Apply__
- [attachment:trac_14471_dynamic_class_hash.patch]
- [attachment:trac_14471-review.patch]
--
Comment:
I think it would be a good idea to show that the hash actually did change.
I extended the new test accordingly, in a review patch.
Positive review, then!
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/14471#comment:33>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.
