#3416: Weierstrass form and Jacobian for cubics and certain other genus-one
curves
------------------------------------------------------------------------------+
Reporter: moretti |
Owner: was
Type: enhancement |
Status: needs_review
Priority: major |
Milestone: sage-5.11
Component: elliptic curves |
Resolution:
Keywords: nagell, weierstrass, cubic, elliptic curves, editor_wstein |
Work issues:
Report Upstream: N/A |
Reviewers: John Cremona, Marco Streng, Nils Bruin
Authors: Niels Duif, Volker Braun |
Merged in:
Dependencies: #12553, #13084, #13458 |
Stopgaps:
------------------------------------------------------------------------------+
Comment (by cremona):
Sorry, I had assumed that the problem would be reproducible. This is with
5.11.beta3 on which I had done nothing at all before adding the three
patches:
{{{
jec@fermat%../../sage -t sage/schemes/elliptic_curves/jacobian.py
Running doctests with ID 2013-06-26-17-52-06-6d628e14.
Doctesting 1 file.
sage -t sage/schemes/elliptic_curves/jacobian.py
**********************************************************************
File "sage/schemes/elliptic_curves/jacobian.py", line 94, in
sage.schemes.elliptic_curves.jacobian.Jacobian
Failed example:
Jacobian(C, morphism=True)
Exception raised:
Traceback (most recent call last):
File "/home/jec/sage-5.11.beta3/local/lib/python2.7/site-
packages/sage/doctest/forker.py", line 486, in _run
self.execute(example, compiled, test.globs)
File "/home/jec/sage-5.11.beta3/local/lib/python2.7/site-
packages/sage/doctest/forker.py", line 845, in execute
exec compiled in globs
File "<doctest sage.schemes.elliptic_curves.jacobian.Jacobian[7]>",
line 1, in <module>
Jacobian(C, morphism=True)
File "lazy_import.pyx", line 313, in
sage.misc.lazy_import.LazyImport.__call__ (sage/misc/lazy_import.c:2475)
File "/home/jec/sage-5.11.beta3/local/lib/python2.7/site-
packages/sage/schemes/elliptic_curves/jacobian.py", line 120, in Jacobian
return Jacobian_of_curve(X, morphism=morphism, **kwds)
File "/home/jec/sage-5.11.beta3/local/lib/python2.7/site-
packages/sage/schemes/elliptic_curves/jacobian.py", line 151, in
Jacobian_of_curve
return Jacobian_of_equation(eqn, curve=curve)
File "/home/jec/sage-5.11.beta3/local/lib/python2.7/site-
packages/sage/schemes/elliptic_curves/jacobian.py", line 235, in
Jacobian_of_equation
X, Y, Z = WeierstrassForm(polynomial, variables=variables,
transformation=True)
TypeError: WeierstrassForm() got an unexpected keyword argument
'transformation'
**********************************************************************
File "sage/schemes/elliptic_curves/jacobian.py", line 192, in
sage.schemes.elliptic_curves.jacobian.Jacobian_of_equation
Failed example:
h = Jacobian(f, curve=Curve(f)); h
Exception raised:
Traceback (most recent call last):
File "/home/jec/sage-5.11.beta3/local/lib/python2.7/site-
packages/sage/doctest/forker.py", line 486, in _run
self.execute(example, compiled, test.globs)
File "/home/jec/sage-5.11.beta3/local/lib/python2.7/site-
packages/sage/doctest/forker.py", line 845, in execute
exec compiled in globs
File "<doctest
sage.schemes.elliptic_curves.jacobian.Jacobian_of_equation[4]>", line 1,
in <module>
h = Jacobian(f, curve=Curve(f)); h
File "lazy_import.pyx", line 313, in
sage.misc.lazy_import.LazyImport.__call__ (sage/misc/lazy_import.c:2475)
File "/home/jec/sage-5.11.beta3/local/lib/python2.7/site-
packages/sage/schemes/elliptic_curves/jacobian.py", line 116, in Jacobian
return Jacobian_of_equation(X, **kwds)
File "/home/jec/sage-5.11.beta3/local/lib/python2.7/site-
packages/sage/schemes/elliptic_curves/jacobian.py", line 235, in
Jacobian_of_equation
X, Y, Z = WeierstrassForm(polynomial, variables=variables,
transformation=True)
TypeError: WeierstrassForm() got an unexpected keyword argument
'transformation'
**********************************************************************
File "sage/schemes/elliptic_curves/jacobian.py", line 200, in
sage.schemes.elliptic_curves.jacobian.Jacobian_of_equation
Failed example:
h([1,-1,0])
Exception raised:
Traceback (most recent call last):
File "/home/jec/sage-5.11.beta3/local/lib/python2.7/site-
packages/sage/doctest/forker.py", line 486, in _run
self.execute(example, compiled, test.globs)
File "/home/jec/sage-5.11.beta3/local/lib/python2.7/site-
packages/sage/doctest/forker.py", line 845, in execute
exec compiled in globs
File "<doctest
sage.schemes.elliptic_curves.jacobian.Jacobian_of_equation[5]>", line 1,
in <module>
h([Integer(1),-Integer(1),Integer(0)])
NameError: name 'h' is not defined
**********************************************************************
File "sage/schemes/elliptic_curves/jacobian.py", line 206, in
sage.schemes.elliptic_curves.jacobian.Jacobian_of_equation
Failed example:
E = h.codomain()
Exception raised:
Traceback (most recent call last):
File "/home/jec/sage-5.11.beta3/local/lib/python2.7/site-
packages/sage/doctest/forker.py", line 486, in _run
self.execute(example, compiled, test.globs)
File "/home/jec/sage-5.11.beta3/local/lib/python2.7/site-
packages/sage/doctest/forker.py", line 845, in execute
exec compiled in globs
File "<doctest
sage.schemes.elliptic_curves.jacobian.Jacobian_of_equation[6]>", line 1,
in <module>
E = h.codomain()
NameError: name 'h' is not defined
**********************************************************************
File "sage/schemes/elliptic_curves/jacobian.py", line 207, in
sage.schemes.elliptic_curves.jacobian.Jacobian_of_equation
Failed example:
E.defining_polynomial()(h.defining_polynomials()).factor()
Exception raised:
Traceback (most recent call last):
File "/home/jec/sage-5.11.beta3/local/lib/python2.7/site-
packages/sage/doctest/forker.py", line 486, in _run
self.execute(example, compiled, test.globs)
File "/home/jec/sage-5.11.beta3/local/lib/python2.7/site-
packages/sage/doctest/forker.py", line 845, in execute
exec compiled in globs
File "<doctest
sage.schemes.elliptic_curves.jacobian.Jacobian_of_equation[7]>", line 1,
in <module>
E.defining_polynomial()(h.defining_polynomials()).factor()
NameError: name 'E' is not defined
**********************************************************************
2 items had failures:
1 of 9 in sage.schemes.elliptic_curves.jacobian.Jacobian
4 of 13 in sage.schemes.elliptic_curves.jacobian.Jacobian_of_equation
[39 tests, 5 failures, 2.61 s]
----------------------------------------------------------------------
sage -t sage/schemes/elliptic_curves/jacobian.py # 5 doctests failed
}}}
Note that
{{{
sage: search_def("WeierstrassForm")
schemes/toric/weierstrass.py:355:def WeierstrassForm(polynomial,
variables=None):
schemes/toric/weierstrass.py:614:def WeierstrassForm_P2(polynomial,
variables=None):
schemes/toric/weierstrass.py:814:def WeierstrassForm_P1xP1(biquadric,
variables=None):
schemes/toric/weierstrass.py:952:def WeierstrassForm_P2_112(polynomial,
variables=None):
}}}
Is there a missing dependency?
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/3416#comment:74>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.
