#10358: New interface with OEIS
-------------------------------------+--------------------------------------
Reporter: was | Owner: tmonteil
Type: defect | Status: needs_review
Priority: critical | Milestone: sage-5.11
Component: combinatorics | Resolution:
Keywords: Cernay2012 days49 | Work issues:
Report Upstream: N/A | Reviewers:
Authors: Thierry Monteil | Merged in:
Dependencies: | Stopgaps:
-------------------------------------+--------------------------------------
Comment (by ncohen):
Helloooooooo !!
I noticed small things
* `find_by_description` does not use `first_result`
* {{{``absolute_value`` - (bool, default False) expliquer le bordel.}}}
* Shouldn't `OEISSequence.fields` be renamed to `_fields` ? It's weird to
have this constant among so many functions in the tab-completion.
* In your deprecation warnings could you replace "oeis" by "oeis()" ? To
emphasize that "oeis" is a function that should be used instead of
"sloane_find" ?
* I am not a big fan of the design of `first_terms` which builds the list
of all terms, and that is subsequently called by `__call__` and
`__getitem__` that ignore most values and return only one. But of course
efficiency is not really a problem here `:-P`
* The documentation of the OEIS module begins a tad harshly. A sentence
saying "The OEIS is an online database for integer sequences, you can
query it through Sage in order to guess how an integer sequence contiues
and what it may mean" would be nice before all Sage examples are given
`:-)`
This being said I like your new code, and I think that it fits well in
`database/`...
Nathann
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/10358#comment:25>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.
