#14837: Implement graph join operation
-----------------------------------------+----------------------------------
       Reporter:  azuge                  |         Owner:  jason, ncohen, rlm
           Type:  enhancement            |        Status:  needs_info        
       Priority:  minor                  |     Milestone:  sage-5.12         
      Component:  graph theory           |    Resolution:                    
       Keywords:  graph join             |   Work issues:                    
Report Upstream:  N/A                    |     Reviewers:  Nathann Cohen     
        Authors:  Alexandre Prusch Züge  |     Merged in:                    
   Dependencies:                         |      Stopgaps:                    
-----------------------------------------+----------------------------------

Comment (by ncohen):

 HMmmmmmmm... And what about changing the behaviour of disjoint_union so
 that depending on the input it either 1) Relabels all vertices to
 consecutive integers; or 2) Relabels them as `(0,u)` and `(1,u)` depending
 on the value of verbose_relabel but *never* leaves the names as they are ?

 Leaving the names as they are is exactly the behaviour of `Graph.union`,
 so it does not make sense to make this a special case of `disjoint_union`.
 This way, one can know from the method's arguments the actual names of the
 future vertices, which is good to have. As it is, there is no way to guess
 as it depends on the graph itself, so it's pretty hard to write a script
 using this method.
 And besides, this behaviour can already be obtained through `Graph.union`.

 Then you could use this `Graph.disjoint_union` from `Graph.join` without
 duplicating the code. And `disjoint_union` would be more reliable too.

 What do you think ?

 If you think that it would be nice but don't have time to do it yourself,
 just tell me and I will.

 Oh, and you can perfectly overwrite this patch with another one. Or you
 can use mercurial queue and upload several patches that are to be applied
 on top of each other, as you prefer.

 Have fuuuuuuuuuun !

 Nathann

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/14837#comment:4>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to