#13589: Controlling C3 to solve once for all the Method Resolution Order issues
for
category classes
----------------------------------------------------------+-----------------
Reporter: nthiery | Owner:
nthiery
Type: defect | Status:
needs_review
Priority: major | Milestone:
sage-5.11
Component: categories | Resolution:
Keywords: method resolution order, C3 | Work issues:
Report Upstream: N/A | Reviewers:
Simon King, Florent Hivert
Authors: Nicolas M. Thiéry, Simon King | Merged in:
Dependencies: #12894, #12876, #11935, #12895, #10193 | Stopgaps:
----------------------------------------------------------+-----------------
Comment (by SimonKing):
One typo in the review patch: "It is sematically equivalent" should be "It
is semantically equivalent". Also I think you mean
{{{
:func:`operator.attrgetter```("cmp_key")``
}}}
not
{{{
:func:`operator.attrgetter```(category)``
}}}
I wonder: You changed the default sort function from `category_sort_key`
to `identity` (as we agreed on by phone), but you do not explicitly use
the now non-default `category_sort_key` when calling c3_sorted_merge in
sage.categories.category, isn't it? That should be fixed.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/13589#comment:72>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.
