#13589: Controlling C3 to solve once for all the Method Resolution Order issues
for
category classes
----------------------------------------------------------+-----------------
Reporter: nthiery | Owner:
nthiery
Type: defect | Status:
needs_review
Priority: major | Milestone:
sage-5.11
Component: categories | Resolution:
Keywords: method resolution order, C3 | Work issues: Add
tests in c3_controlled
Report Upstream: N/A | Reviewers:
Simon King, Florent Hivert
Authors: Nicolas M. Thiéry, Simon King | Merged in:
Dependencies: #12894, #12876, #11935, #12895, #10193 | Stopgaps:
----------------------------------------------------------+-----------------
Changes (by {'newvalue': u'Nicolas M. Thi\xe9ry, Simon King', 'oldvalue':
u'Nicolas M. Thi\xe9ry'}):
* work_issues: => Add tests in c3_controlled
* author: Nicolas M. Thiéry => Nicolas M. Thiéry, Simon King
Comment:
Hooray!!!!! Did you see what the patchbot plugins have to tell??
- Doctest coverage: `+Missing doctests misc/c3_controlled.pyx 18 / 20 =
90%`. That's my fault, I need to add tests for the functions I introduced.
- Startup modules: Of course, there is now c3_controlled. No surprise and
now problem
- Startup time:
{{{
-Main: 1.5331 sec (30 samples, std_dev=0.0508)
-Ticket: 1.5186 sec (30 samples, std_dev=0.0525)
+real 0m1.482s
+user 0m1.243s
+sys 0m0.227s
+9, 1.5900211334228516, 1.6482288837432861, 1.5097029209136963,
1.4862918853759766, 1.623434066772461, 1.4829378128051758,
1.582334041595459, 1.6098928451538086, 1.554724931716919,
1.5065560340881348, 1.495615005493164, 1.5109539031982422,
1.5232598781585693, 1.4945759773254395, 1.4797320365905762,
1.6103341579437256, 1.5885298252105713, 1.5899219512939453,
1.4962730407714844, 1.5993151664733887, 1.5715739727020264,
1.5021510124206543, 1.5274248123168945, 1.4769189357757568,
1.6029491424560547, 1.625540018081665, 1.6075868606567383,
1.5096728801727295, 1.6023800373077393]
-Average decrease of 0.014 secs or 0.94%.
+Main: 1.5629 sec (30 samples, std_dev=0.0471)
+Ticket: 1.5551 sec (30 samples, std_dev=0.0561)
+
+Average decrease of 0.0079 secs or 0.5%.
-No statistically significant difference.
+With 32% confidence, startup time decreased by at least 0.25%
+With 44% confidence, startup time decreased by at least 0.1%
}}}
In other words, the problem is solved!
I think I can give your patch a positive review. My patches are big enough
so that I should add me as author, and someone else needs to review them.
And I will soon add the missing tests in C3_controlled.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/13589#comment:63>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.
