#14519: Cythonize ElementWrapper and make parent the first argument
-----------------------------------------+----------------------------------
Reporter: tscrim | Owner: tscrim
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-5.11
Component: performance | Resolution:
Keywords: cython ElementWrapper | Work issues:
Report Upstream: N/A | Reviewers:
Authors: Travis Scrimshaw | Merged in:
Dependencies: #14143 #14015 #14516 | Stopgaps:
-----------------------------------------+----------------------------------
Comment (by tscrim):
Okay, I figured out what was going wrong. For the nested class,
`TestParent4` did not implement a `__ne__` and is not a
`UniqueRepresentation`, so it does not by default check `not __eq__`. In
the `ElementWrapper`, I'm testing using `__ne__`.
For the posets, the problem was that `ElementWrapper` was checking if the
second argument was a `Parent` class, rather than if the first argument is
not a `Parent`. Thus wrapping a `Set`, which is a `Parent`, caused the
deprecation warning and a swap to occur.
The rest of the errors were trivial in the sense I needed to put a parent
as the first argument. In summary: err0rz b3 pwnd.
Best,[[BR]]
Travis
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/14519#comment:8>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.
