#14833: Make choosing irreducible polynomials independent of finite field
implementations
--------------------------------+-------------------------------------------
Reporter: pbruin | Owner: cpernet
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-5.12
Component: finite rings | Resolution:
Keywords: polynomials | Work issues:
Report Upstream: N/A | Reviewers:
Authors: Peter Bruin | Merged in:
Dependencies: #14832 | Stopgaps:
--------------------------------+-------------------------------------------
Comment (by pbruin):
Replying to [comment:3 jpflori]:
> It may be better to use a function decorator to do the caching of the
is_conway method, i.e. use @cached_method.
OK, I'll fix this as soon as I have time, unless you or someone else does
it first.
> And is there any point to prevent setting the default return value for
finite fields explicitely constructed with conway polynomials?
> (i.e. removing what would be the equivalent of "self._is_conway = True"
after the "modulus == "conway"" tests? to set the default value of the
cached_method you can use "self.is_conway.set_cache(True)".)
That might be slightly more elegant, but the test for `modulus ==
'conway'` is now in `PolynomialRing.irreducible_element`, which is not
directly related to finite fields, so we would need an additional check in
the finite field constructor. I'm not sure if it is worth it: checking
whether we have a Conway polynomial is (hopefully) very fast (since the
database was loaded when we looked up the Conway polynomial), and
`is_conway()` is currently only used for Sage <-> Gap conversion.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/14833#comment:4>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.
