#14516: Refactoring of crystals for speedup
-------------------------------------+-------------------------------------
Reporter: tscrim | Owner: sage-combinat
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-5.12
Component: combinatorics | Resolution:
Keywords: crystals speedup, | Merged in:
days49 | Reviewers: Anne Schilling
Authors: Travis Scrimshaw | Work issues:
Report Upstream: N/A | Dependencies: #2023, #14402,
Branch: | #14413, #14143, #12940
Stopgaps: |
-------------------------------------+-------------------------------------
Comment (by aschilling):
Replying to [comment:21 tscrim]:
> Anne, could you do a double-check to make sure everything is consistent
and works for you? Thanks.
I still get the above mentioned errors:
{{{
sage -t affine_permutation.py
**********************************************************************
File "affine_permutation.py", line 241, in
sage.combinat.affine_permutation.AffinePermutation.index_set
Failed example:
A.index_set()
Expected:
[0, 1, 2, 3, 4, 5, 6, 7]
Got:
(0, 1, 2, 3, 4, 5, 6, 7)
**********************************************************************
File "affine_permutation.py", line 2077, in
sage.combinat.affine_permutation.AffinePermutationGroupGeneric.index_set
Failed example:
AffinePermutationGroup(['A',7,1]).index_set()
Expected:
[0, 1, 2, 3, 4, 5, 6, 7]
Got:
(0, 1, 2, 3, 4, 5, 6, 7)
**********************************************************************
File "affine_permutation.py", line 2088, in
sage.combinat.affine_permutation.AffinePermutationGroupGeneric.reflection_index_set
Failed example:
AffinePermutationGroup(['A',7,1]).index_set()
Expected:
[0, 1, 2, 3, 4, 5, 6, 7]
Got:
(0, 1, 2, 3, 4, 5, 6, 7)
**********************************************************************
3 items had failures:
1 of 3 in
sage.combinat.affine_permutation.AffinePermutation.index_set
1 of 2 in
sage.combinat.affine_permutation.AffinePermutationGroupGeneric.index_set
1 of 2 in
sage.combinat.affine_permutation.AffinePermutationGroupGeneric.reflection_index_set
[335 tests, 3 failures, 6.17 s]
}}}
Did you post an updated patch? I cannot see any mention of
affine_permutation in your patch.
Anne
--
Ticket URL: <http://trac.sagemath.org/ticket/14516#comment:22>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.
