#14516: Refactoring of crystals for speedup
-------------------------------------+-------------------------------------
Reporter: tscrim | Owner: sage-combinat
Type: enhancement | Status: positive_review
Priority: major | Milestone: sage-5.12
Component: combinatorics | Resolution:
Keywords: crystals speedup, | Merged in:
days49 | Reviewers: Anne Schilling
Authors: Travis Scrimshaw | Work issues:
Report Upstream: N/A | Dependencies: #2023, #14402,
Branch: | #14413, #14143, #12940
Stopgaps: |
-------------------------------------+-------------------------------------
Old description:
> In order to speed up many of the crystals computations, I'm proposing the
> following:
>
> - Cythonize `CrystalOfLetters`
> - Make `index_set()` a cached method. Subsequently this requires it to be
> returned as a tuple instead of a list
> - Make different letters classes, one for integers (classical types), one
> for tuples (exceptional/spin)
> - Store by caching result of `_element_constructor_()` the elements of
> `CrystalOfLetters`.
>
> See #14686 for a followup.
>
> Apply:
>
> * [attachment:trac_14516-crystals_speedup-ts.patch]
> * [attachment:trac_14516-review-as.patch]
New description:
In order to speed up many of the crystals computations, I'm proposing the
following:
- Cythonize `CrystalOfLetters`
- Make `index_set()` a cached method. Subsequently this requires it to be
returned as a tuple instead of a list
- Make different letters classes, one for integers (classical types), one
for tuples (exceptional/spin)
- Store by caching result of `_element_constructor_()` the elements of
`CrystalOfLetters`.
See #14686 for a followup.
Apply:
* [attachment:trac_14516-crystals_speedup-ts.patch]
--
Comment (by tscrim):
Here's the fixed patch.
For patchbot:
Apply: trac_14516-crystals_speedup-ts.patch
--
Ticket URL: <http://trac.sagemath.org/ticket/14516#comment:24>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.
