#5566: [with patch, needs review] Symmetric Groebner bases and Infinitely
Generated Polynomial Rings
---------------------------------+------------------------------------------
Reporter: SimonKing | Owner: SimonKing
Type: enhancement | Status: new
Priority: major | Milestone: sage-4.0
Component: commutative algebra | Keywords: Symmetric Ideal
---------------------------------+------------------------------------------
Comment(by malb):
Replying to [comment:35 SimonKing]:
> First, some general questions:
>
> 1. Should previous versions of a patch be preserved, or is it better to
overwrite the old patch with the new version?
I don't think we established a good practice here yet. But it is certainly
easier for the release manager if there is only one patch or a clear
description what to apply when.
> 2. Should there only be ''one'' patch, or should there be one starter
patch, and all other patches only define the change with respect to the
previous patch (hence, one has to apply a sequence of one big and perhaps
10 small patches)?
It depends. I would say: This ticket should be closed soon. The patch is
way too big already. So in this case new patches (in different tickets)
should be created.
> Anyway. This time I created a new patch {{{SymmetricIdeals.2.patch}}},
that should be applied first (e.g., to sage-3.4.1.rc3). After that, please
apply {{{SymmetricIdealsCorrection.patch}}}, that corrects some doc tests.
>
> Changes with respect to previous versions:
> - Major improvement of the documentation. I did {{{sage -docbuild
reference html}}}, and it looks good in the browser.
> - Now any class has a {{{X==loads(dumps(X))}}} doc test. In particular,
the Cython class {{{SymmetricReductionStrategy}}} is provided with
pickling.
> - The performance is further improved: With {{{prune}}}, I found that a
considerable amount of time was spent with {{{deepcopy}}}. Since I know
that the object to be copied is a dict whose values are lists of integers,
it is cheaper to do the copy manually. I am surprised that it makes such a
big difference!
>
> After applying {{{SymmetricIdealsCorrection.patch}}}, the doc tests of
my files pass for me.
>
> One question to the referee: As mentioned in a comment above, I try to
be clever, i.e., in {{{SymmetricIdeal.symmetrisation()}}} I only apply
elementary transpositions rather than the full symmetric group. I believe
it works, but it is a difference to what Aschenbrenner and Hillar
suggested. Shall I point it out in the documentation
Yes, that should be pointed out clearly.
Let me know what the 'final' version of your patch is and then I'll review
it.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/5566#comment:36>
Sage <http://sagemath.org/>
Sage - Open Source Mathematical Software: Building the Car Instead of
Reinventing the Wheel
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
