#15022: adjacency graph for a triangulation
-------------------------------------------------+-------------------------
       Reporter:  ursula                         |        Owner:
           Type:  enhancement                    |       Status:
       Priority:  minor                          |  needs_review
      Component:  combinatorics                  |    Milestone:  sage-5.12
       Keywords:                                 |   Resolution:
        Authors:  Stephen Farley, Ursula         |    Merged in:
  Whitcher                                       |    Reviewers:  Nathann
Report Upstream:  N/A                            |  Cohen
         Branch:                                 |  Work issues:
   Dependencies:                                 |       Commit:
                                                 |     Stopgaps:
-------------------------------------------------+-------------------------
Changes (by ncohen):

 * reviewer:   => Nathann Cohen


Old description:

> This function creates the adjacency graph associated to a triangulation
> of a point configuration.  Such a graph has one node for each top-
> dimensional simplex in the triangulation.  Two nodes are joined by an
> edge if the corresponding simplices intersect in a simplex of codimension
> 1.

New description:

 This function creates the adjacency graph associated to a triangulation of
 a point configuration.  Such a graph has one node for each top-dimensional
 simplex in the triangulation.  Two nodes are joined by an edge if the
 corresponding simplices intersect in a simplex of codimension 1.

 Apply:

 * [attachment:TriangulationGraph2.patch]
 * [attachment:trac_15022-rev.patch]

--

Comment:

 Helloooooo !!

 I had forgotten to tell you about the 80 characters maximum length for
 lines (it's not a veeeeeeeeeery hard rule but we try to stick to it
 whenever possible), so I wrote a small reviewer's patch to apply on top of
 yours. If you agree with it, you can then set this ticket to
 `positive_review` !

 I also remove spaces at the end of some lines (we try to avoid that too),
 and added a pointer toward another graph that one may want to obtain from
 a triangulation, in the method's documentation.

 Oh, and I also changed the indentation of your AUTHORS block, as it was
 not displayed correctly in the html doc.

 I think that it is ready to go now `:-)`

 Have fuuuuuuuuuuuuuuuuuuuuunnn !!

 Nathann

--
Ticket URL: <http://trac.sagemath.org/ticket/15022#comment:6>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to