#3416: Weierstrass form and Jacobian for cubics and certain other genus-one
curves
-------------------------------------+-------------------------------------
Reporter: moretti | Owner: was
Type: enhancement | Status: needs_work
Priority: major | Milestone: sage-5.12
Component: elliptic curves | Resolution:
Keywords: nagell, | Merged in:
weierstrass, cubic, elliptic | Reviewers: John Cremona, Marco
curves, editor_wstein | Streng, Nils Bruin
Authors: Niels Duif, | Work issues:
Volker Braun | Commit:
Report Upstream: N/A | Stopgaps:
Branch: |
Dependencies: #12553, #13084, |
#13458 |
-------------------------------------+-------------------------------------
Changes (by jdemeyer):
* status: positive_review => needs_work
Comment:
Sorry, there are some issues with these patches:
Most importantly, the doctests for `Jacobian_magma_from_plane_curve` don't
actually use the function `Jacobian_magma_from_plane_curve`. So the
function which is "useful for doctesting" doesn't seem to be used in any
doctest.
Then some details: I would replace
{{{
sage: x,y,z=PolynomialRing(QQ,3,'xyz').gens()
}}}
by
{{{
sage: R.<x,y,z> = PolynomialRing(QQ,3)
}}}
or
{{{
sage: R.<x,y,z> = QQ[]
}}}
And also replace
{{{
sage: f = x**5 + 1184*x**3 + 1846*x**2 + 956*x + 560
}}}
by
{{{
sage: f = x^5 + 1184*x^3 + 1846*x^2 + 956*x + 560
}}}
--
Ticket URL: <http://trac.sagemath.org/ticket/3416#comment:80>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.
