#3416: Weierstrass form and Jacobian for cubics and certain other genus-one 
curves
-------------------------------------+-------------------------------------
       Reporter:  moretti            |        Owner:  was
           Type:  enhancement        |       Status:  needs_review
       Priority:  major              |    Milestone:  sage-5.12
      Component:  elliptic curves    |   Resolution:
       Keywords:  nagell,            |    Merged in:
  weierstrass, cubic, elliptic       |    Reviewers:  John Cremona, Marco
  curves, editor_wstein              |  Streng, Nils Bruin
        Authors:  Niels Duif,        |  Work issues:
  Volker Braun                       |       Commit:
Report Upstream:  N/A                |     Stopgaps:
         Branch:                     |
   Dependencies:  #12553, #13084,    |
  #13458                             |
-------------------------------------+-------------------------------------

Comment (by cremona):

 Replying to [comment:86 vbraun]:
 > I've added the missing import, should work now.
 That's odd as I would not have expected it to be necessary to import SR
 for a doctest.

 Anyway, that function is still wrong since 2 lines later it refers to P
 which I presume is a point on the curve, but there is no parameter P.
 Shall we just delete this completely redundant function?

 The next function {{{Jacobian_magma_from_plane_curve}}} needs a minor fix
 in the last line since rings is not imported.  It's fine with
 {{{
     from sage.rings.all import QQ
     return EllipticCurve(QQ, eval(s))
 }}}

--
Ticket URL: <http://trac.sagemath.org/ticket/3416#comment:87>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to