#15029: Implement similarity classes over principal ideal local rings of length
two
-------------------------------------------------+-------------------------
Reporter: amri | Owner: amri
Type: enhancement | Status:
Priority: major | needs_review
Component: combinatorics | Milestone: sage-5.12
Keywords: similarity classs, matrices, | Resolution:
local rings | Merged in:
Authors: Amritanshu Prasad | Reviewers: tscrim
Report Upstream: N/A | Work issues:
Branch: | Commit:
Dependencies: #14907 | Stopgaps:
-------------------------------------------------+-------------------------
Comment (by tscrim):
Hey Amri,
It seems like you've created 2 classes which are basically computing a few
methods and don't contain helper methods. I would instead move these to
(module-level) functions in `similarity_class_type.py` which take the
`data, q, selftranspose, invertible` as arguments since there is:
- no complicated internal state across multiple functions,
- no complicated/expensive standardization or preparation needed on the
inputs,
- no element classes,
- no classes inheriting from these.
Two other minor points:
- Could you use the arXiv autolink format: {{{:arxiv.org:`1212.6157`}}}?
- Could you remove the `[mq]:...` line from the patch header by doing a
`qrefresh -e`?
Thanks,[[BR]]
Travis
--
Ticket URL: <http://trac.sagemath.org/ticket/15029#comment:2>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.
