#15055: minor cleanup in incidence structures
----------------------------------------+-----------------------------
Reporter: chapoton | Owner:
Type: enhancement | Status: needs_review
Priority: minor | Milestone: sage-5.12
Component: combinatorics | Resolution:
Keywords: incidence | Merged in:
Authors: Frédéric Chapoton | Reviewers: Nathann Cohen
Report Upstream: N/A | Work issues:
Branch: u/chapoton/trac15055 | Commit:
Dependencies: | Stopgaps:
----------------------------------------+-----------------------------
Changes (by ncohen):
* reviewer: => Nathann Cohen
Comment:
Helloooo !!
Well, your patch looks good but your branch contains two commits, the
second just fixing a typo. I think that it does not change anything, for
if I got everything right your two commits will appear as only one when
your patch will be merged into Sage.
This being said, it is very easy to merge (=squash) commits with git, so
if you want to give it a try here's how it works :
http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html
And you can decide whether you want to merge these two commits together,
and set this ticket to `positive_review` on my behalf when you are set
`:-)`
Nathann
--
Ticket URL: <http://trac.sagemath.org/ticket/15055#comment:3>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.
