#14982: Coercion from rings with coerce_embedding into constructions over those
rings is broken
-------------------------------------------------+-------------------------
Reporter: mmezzarobba | Owner:
Type: defect | Status:
Priority: major | needs_review
Component: coercion | Milestone: sage-6.0
Keywords: embedding | Resolution:
Authors: Marc Mezzarobba | Merged in:
Report Upstream: N/A | Reviewers:
Branch: | Work issues:
u/mmezzarobba/coerce_embeddings | Commit:
Dependencies: | Stopgaps:
-------------------------------------------------+-------------------------
Comment (by mmezzarobba):
Replying to [comment:6 SimonKing]:
> Replying to [comment:5 SimonKing]:
> > I couldn't tell, unless you give me a pointer to the new workfow. What
do I need to do, when not a patch but a brunch (aaahm, branch...) is
given?
If you already have a git-based installation of sage (i.e. you once did
something like `git clone https://github.com/sagemath/sage.git && git
checkout -b origin/build_system && make build`) and a remote that refers
to the trac server, you just need to fetch and checkout the branch
`u/mmezzarobba/coerce_embeddings` from trac and review the three commits
on top of `build_system` just like you would if they were patches you just
applied.
Otherwise, hmm, I guess it is easier to set up a git-based installation
than to try to do the review with Mercurial... See
http://sagemath.github.io/git-developer-guide/
(or ask!) in case you need more information on how to do that.
If the branch was based off an old version of sage, I guess you might also
want to check that it merges cleanly, but here it is already a descendant
of the last beta.
> For example, when I look at the "commits" link, I see that there are
three commits, and only one of them seems to refer to this ticket. So,
what do I do with the other commits, review-wise? I see that there is a
discussion on sage-git on the question what exactly is to be reviewed.
Would I only review the last commit (since its commit message refers to
this ticket)? Would I review all three commits (but then I would
potentially also review dependencies that are reviewed elsewhere!)?
All three commits need review, and none of them is part of any other
ticket. I am not sure if/where the ticket number should go in the commit
logs (perhaps it would make more sense to put it in the message associated
to the ''merge'' commit?). The last commit of the branch is also the one
that fixes the issue the ticket is about, so I put it here, but I can
rewrite history to add it to the two other commits if you want.
--
Ticket URL: <http://trac.sagemath.org/ticket/14982#comment:7>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.
