#14875: Remove CombinatorialClass from DyckWords
------------------------------------+-----------------------------
       Reporter:  tscrim            |        Owner:  sage-combinat
           Type:  enhancement       |       Status:  needs_review
       Priority:  major             |    Milestone:  sage-5.12
      Component:  combinatorics     |   Resolution:
       Keywords:                    |    Merged in:
        Authors:  Travis Scrimshaw  |    Reviewers:
Report Upstream:  N/A               |  Work issues:
         Branch:                    |       Commit:
   Dependencies:  #12453            |     Stopgaps:
------------------------------------+-----------------------------

Comment (by darij):

 Uploaded my review patch. Please look over it as I'm not 100% sure I
 always caught your correct intentions.

 I took the freedom to remove {{{def is_a_prefix}}} (and replace all
 reference to it by ones to {{{is_a}}}), since it was doing precisely the
 same thing as {{{def is_a}}}. This might theoretically have caused some
 issues in other places, but at least the sage/combinat/*.py files doctest
 correctly (I have only done {{{./sage -bt devel/sage-
 main/sage/combinat}}}; for doctesting the whole library I don't have the
 time right now).

 Why did you remove the {{{an_element()}}} doctests?

--
Ticket URL: <http://trac.sagemath.org/ticket/14875#comment:5>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.

Reply via email to