#7539: primesieve spkg
---------------------------------+-------------------------------
Reporter: GeorgSWeber | Owner: ohanar
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-5.12
Component: number theory | Resolution:
Keywords: | Merged in:
Authors: Kim Walisch | Reviewers: R. Andrew Ohana
Report Upstream: N/A | Work issues:
Branch: | Commit:
Dependencies: | Stopgaps:
---------------------------------+-------------------------------
Changes (by {'newvalue': u'Kim Walisch', 'oldvalue': u'ohanar'}):
* status: new => needs_review
* reviewer: => R. Andrew Ohana
* author: ohanar => Kim Walisch
Old description:
> This ticket was split away from #7013:
>
> The goal of this ticket is to create an spkg for primesieve
> (http://primesieve.googlecode.com) which provides the functionality of
> primesieve is a shared library.
>
> Install [http://wstein.org/home/ohanar/primesieve/primesieve-3.4.p2.spkg
> primesieve-3.4.p2.spkg].
>
> Apply [http://wstein.org/home/ohanar/primesieve/trac7539_initial.patch
> trac7539_initial.patch] and either
> [http://wstein.org/home/ohanar/primesieve/trac7539_standard.patch
> trac7539_standard.patch] xor
> [http://wstein.org/home/ohanar/primesieve/trac7539_optional.patch
> trac7539_optional.patch].
New description:
This ticket was split away from #7013:
The goal of this ticket is to create an spkg for primesieve
(http://primesieve.googlecode.com) which provides the functionality of
primesieve is a shared library.
----
Installation instructions:
1. Add
[[https://primesieve.googlecode.com/files/primesieve-4.4.spkg:primesieve-4.4.spkg]]
to spkg/standard.
1. Apply [attachment:02_primesieve-sage-main.patch] to the Sage library
repository.
1. Apply [attachment:primesieve-sage-root.patch] to the root repository.
--
Comment:
I've reviewed this code while Kim was writing it, so other than the
following questions/concerns, it has a positive review from me.
1. What is our policy with licencing files in the Sage library. This patch
adds two files which are marked as BSD licensed, is this ok? (given that
the Sage library as a whole is GPL licensed)
1. What is the current policy on adding new standard SPKGs? At some point
it was decided that all new SPKGs had to be optional before they were made
standard, but this requirement has been repeatedly ignored.
1. Would it make sense stripping out the directory src/src/apps/gui? This
would reduce the size of the spkg by over half.
P.S. Kim, would you please update the list of developers on trac's
homepage so people know who you are.
--
Ticket URL: <http://trac.sagemath.org/ticket/7539#comment:22>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.
