#15143: Improvements to SetPartitions
-----------------------------+---------------------------------------------
Reporter: tscrim | Owner: sage-combinat
Type: | Status: needs_review
enhancement | Milestone: sage-5.12
Priority: major | Resolution:
Component: | Merged in:
combinatorics | Reviewers: Darij Grinberg, Mike Zabrocki
Keywords: | Work issues:
Authors: Travis | Commit:
Scrimshaw | Stopgaps:
Report Upstream: N/A |
Branch: |
Dependencies: #14234 |
-----------------------------+---------------------------------------------
Comment (by darij):
Hi Travis,
You don't want s to be an "ordered set partition (i.e., set composition)
of `[r]` where `r\leq k`"; you want it to be an ordered set partition of a
SUBSET of `[k]` (which may and may not be an initial interval). See this
doctest:
{{{
t = OrderedSetPartition([[2], [3,4]])
}}}
where it is not an initial interval. Generally, your r's should be k's.
I'm fine with the rest of your changes. Once you've fixed the ordered set
partition action docstring, you can set this to positive_review as far as
I am concerned. Sorry that I can't help with zabrocki's doctest failure as
I'm not near sage right now.
Best regards (also thanks for the ordered set partition review),\\ Darij
--
Ticket URL: <http://trac.sagemath.org/ticket/15143#comment:17>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.
