#5834: [with patch, positive review] Improvements to quadratic_forms/extras/py
-----------------------------+----------------------------------------------
Reporter: cremona | Owner: justin
Type: enhancement | Status: new
Priority: minor | Milestone: sage-4.0
Component: quadratic forms | Keywords: quadratic forms
-----------------------------+----------------------------------------------
Comment(by jonhanke):
This patch looks good, and I recommend it be approved.
A few comments:
- There is a {{{quadratic_nonresidue()}}} routine in
{{{integer_mod_ring.py}}} which might benefit from using the
{{{least_quadratic_residue()}}} routine.
- What is the procedure for adding functionality present for rationals
to integers? It might be useful for both integer and rational types to
call the {{{is_padic_square()}}} method without explicit rational
coercion.
Also, in an attached patch I made some very minor changes to the
quadratic_form code where this replaced previous functionality.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/5834#comment:5>
Sage <http://sagemath.org/>
Sage - Open Source Mathematical Software: Building the Car Instead of
Reinventing the Wheel
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
