#5736: [with patch, needs review] Improve doctest coverage for
sage/modular/hecke
---------------------------+------------------------------------------------
Reporter: davidloeffler | Owner: davidloeffler
Type: defect | Status: assigned
Priority: major | Milestone: sage-4.0
Component: modular forms | Keywords:
---------------------------+------------------------------------------------
Comment(by mabshoff):
Now the truly puzzling thing is this:
* The above failures are in William's tree on sage.math - I ran them
there.
* When I take those two patches and import them into my clean 3.4.2.rc0
tree in /scratch on sage.math all doctests passs.
William's testing tree seems to be a clone from a tree that has the
following patches in sage-main:
{{{
changeset: 12151:e0257aa492ab
tag: tip
user: William Stein <[email protected]>
date: Sat May 02 22:56:24 2009 -0700
summary: trac #5968 -- part 2 -- increase doctest coverage of
sage/modular/modsym/modular_symbols.py from 0% to 100%
changeset: 12150:673cc9b82a7d
user: William Stein <[email protected]>
date: Sat May 02 22:46:52 2009 -0700
summary: trac 5968 -- increase doctest coverage of
sage/modular/modsym/modular_symbols.py from 0% to 100%
changeset: 12149:901f4946fd7e
user: William Stein <[email protected]>
date: Sat May 02 02:15:34 2009 -0700
summary: trac #5882 -- part 4 -- mop up some issues with overzealous
changes to matrix_morphism.
changeset: 12148:312499531bcb
user: William Stein <[email protected]>
date: Sat May 02 01:31:38 2009 -0700
summary: trac #5882 -- part 3 of "implement general package for
finitely generated not-necessarily free R-modules"
changeset: 12147:82b9ade5605a
user: William Stein <[email protected]>
date: Sat May 02 01:48:24 2009 -0700
summary: trac #5882 (part 2) -- implement general package for finitely
generated not-necessarily free R-modules
changeset: 12146:6023d9680d5e
user: William Stein <[email protected]>
date: Thu Apr 30 13:30:21 2009 -0700
summary: trac #5882 -- part 1 of implementation of finitely generated
modules over a PID
changeset: 12145:9ee83eda286e
user: William Stein <[email protected]>
date: Sat May 02 01:38:52 2009 -0700
summary: trac #5887 -- major bugs in morphisms of R-modules (rebased
against 3.4.2.rc0)
}}}
So I assume that his build directory contains crap from those patches that
cause these failures that a {{{sage -b}}} does not fix since there are no
dependencies when cloning from the rc0 revision. A {{{sage -ba}}} while
using the sage-0 clone would clear this up, but since this isn't my tree I
will not do so :)
In the end this patch should be reviewed on a truly clean tree, so I am
changing this patch to "needs review".
Thoughts?
Cheers,
Michael
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/5736#comment:22>
Sage <http://sagemath.org/>
Sage - Open Source Mathematical Software: Building the Car Instead of
Reinventing the Wheel
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---