#13046: Equimultiple liftings of curves over finite fields
-------------------------------------+-------------------------------------
Reporter: minz | Owner: AlexGhitza
Type: enhancement | Status: positive_review
Priority: minor | Milestone: sage-5.13
Component: algebraic | Resolution:
geometry | Merged in:
Keywords: deformation | Reviewers: William Stein, Max
theory, plane curves | Leiblich
Authors: Moritz Minzlaff | Work issues:
Report Upstream: N/A | Commit:
Branch: | Stopgaps:
Dependencies: #12995 |
-------------------------------------+-------------------------------------
Changes (by was):
* status: needs_review => positive_review
Comment:
REFEREE REPORT:
It looks good!
More precisely, I (William Stein) read the code for style, and Max
Leiblich (an algebraic geometer) read the code for the mathematics, and we
both agree it looks good.
Well, there is one unusual thing. There are backslashes in the comments
so they occupy less than 80 characters, but when read, are wide. I've
never seen this before anywhere in Sage/Python code. I'm not sure whether
we should allow it or not. I'll leave this to the release manager.
--
Ticket URL: <http://trac.sagemath.org/ticket/13046#comment:10>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.