#15279: RootSystem __init__ builds the dual twice, breaking initialization of
non-
crystallographic root systems
----------------------------------------------+----------------------------
Reporter: darij | Owner:
Type: defect | Status:
Priority: major | positive_review
Component: combinatorics | Milestone: sage-5.13
Keywords: root-system, sage-combinat | Resolution:
Authors: Darij Grinberg | Merged in:
Report Upstream: N/A | Reviewers: Travis
Branch: | Scrimshaw
Dependencies: | Work issues:
| Commit:
| Stopgaps:
----------------------------------------------+----------------------------
Comment (by nthiery):
Replying to [comment:6 jdemeyer]:
> Replying to [comment:4 nthiery]:
> > This sounds like a merge that went wrong
> It would be interesting to know why/how it went wrong. The patch is from
#5794, 4 years ago.
>
> Interestingly, the patch
[attachment:trac_5794-exceptional.patch:ticket:5794] on Trac is correct,
it does remove the duplicate line. However, the patch which is merged
(revision `-r13366` in Mercurial) has a different commit message
({{{trac_5794-exceptional.patch modified for combinat server}}}) and does
''not'' remove that line. I can only hope that the "combinat server"
doesn't make these mistakes any more.
Not having duplication between patches on the combinat server and on trac
and not having to rebase constantly, like we will have with the new
workflow, will certainly help ...
Thanks for tracking this down!
--
Ticket URL: <http://trac.sagemath.org/ticket/15279#comment:11>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.
