#15279: RootSystem __init__ builds the dual twice, breaking initialization of
non-
crystallographic root systems
----------------------------------------------+----------------------------
Reporter: darij | Owner:
Type: defect | Status: closed
Priority: major | Milestone: sage-5.13
Component: combinatorics | Resolution: fixed
Keywords: root-system, sage-combinat | Merged in:
Authors: Darij Grinberg | sage-5.13.beta1
Report Upstream: N/A | Reviewers: Travis
Branch: | Scrimshaw
Dependencies: | Work issues:
| Commit:
| Stopgaps:
----------------------------------------------+----------------------------
Changes (by darij):
* cc: bump (added)
Comment:
I am CCing Daniel Bump and Mike Hansen; maybe they can shed more light on
the question what exactly ended up merged from #5794.
So these seem to be the #5794-related commits in the log:
{{{
changeset: 13469:7d776d3652ea
user: Nicolas M. Thiery <[email protected]>
date: Thu Nov 19 12:23:11 2009 +0100
summary: [mq]: trac_5794-long-time-nt.patch
[...]
changeset: 13368:2fcea95a7e9c
user: Mike Hansen <[email protected]>
date: Thu Nov 19 08:26:08 2009 -0800
summary: ReST fixes and improvements
changeset: 13367:4a11faf380b3
user: Daniel Bump <[email protected]>
date: Wed May 20 13:55:19 2009 -0700
summary: Further exceptional branching rules
changeset: 13366:ffe6380fbc20
user: Daniel Bump <[email protected]>
date: Tue May 12 21:56:35 2009 -0700
summary: trac_5794-exceptional.patch modified for combinat server
changeset: 13365:a28740f742ec
user: Mike Hansen <[email protected]>
date: Thu Nov 19 08:26:00 2009 -0800
summary: imported patch trac_5794-continued-combinat
changeset: 13364:e75cad2172eb
user: Mike Hansen <[email protected]>
date: Thu Nov 19 08:25:57 2009 -0800
summary: imported patch cartan_type_temporary-1.patch
changeset: 13363:359efb582d39
user: Mike Hansen <[email protected]>
date: Thu Nov 19 08:25:56 2009 -0800
summary: this temporary patch to be taken down when root system and
5794 patches stabilize.
changeset: 13362:3fef40a05bb4
user: Daniel Bump <[email protected]>
date: Wed May 06 13:17:39 2009 -0700
summary: trac_5794-revised.patch modified for combinat server
}}}
I can tell that
changeset 13469 == trac_5794-long-time-nt.patch (modulo fuzz)
and
changeset 13368 == trac_5794-reviewer-nt.patch.
Furthermore,
changeset 13367 differs from trac_5794-more-exceptional.patch only in
having {{{is_irreducible}}} and {{{is_reducible}}} in lieu of
{{{is_atomic}}} and {{{is_compound}}}.
The difference between changeset 13366 and trac_5794-exceptional.patch is
more substantial, and is what caused the bug in the present ticket.
Someone else should look into the diff to check if this is the only issue
caused!
The difference between changeset 13365 and trac_5794-continued.patch is
again only in irreducible-vs-atomic and reducible-vs-compound.
Changeset 13364 is not an attachment on #5794 and all it does is replacing
some "reducible" by "compound" resp. "irreducible" by "atomic".
Changeset 13363 ("this temporary patch to be taken down when root system
and 5794 patches stabilize.") seems not to be from the #5794 attachments
either, and I don't really understand what it does. I don't know if anyone
has ever "taken it down" or reverted its edits.
Changeset 13362 has noticeable differences from trac_5794-revised.patch
and maybe someone should look into that.
--
Ticket URL: <http://trac.sagemath.org/ticket/15279#comment:15>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.
