#5968: [with patch; needs review] increase doctest coverage of
sage/modular/modsym/modular_symbols.py from 0% to 100%
---------------------------+------------------------------------------------
Reporter: was | Owner: was
Type: defect | Status: new
Priority: major | Milestone: sage-4.0
Component: number theory | Keywords:
---------------------------+------------------------------------------------
Comment(by davidloeffler):
I have one microscopically insignificant quibble: might it not be better
to add a couple of minus signs into the {{{__cmp__}}} method, changing it
to
{{{
if not isinstance(other, ModularSymbol):
return cmp(type(self), type(other))
return cmp((self.__space,-self.__i,self.__alpha,self.__beta),
(other.__space,-other.__i,other.__alpha,other.__beta))
}}}
?
This is somehow the sort order that "feels most natural" to me -- so X^2^Y
comes before XY^2^. This would then need fewer changes to other files, but
of course it means most of the new doctests in your file would need
rewriting :-). Also, what is the reasoning behind introducing the space in
the {{{_repr_}}} method? I would advocate leaving {{{_repr_}}} as is
unless there is a pressing reason to change it, in order to minimise the
likelihood of breaking user code.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/5968#comment:3>
Sage <http://sagemath.org/>
Sage - Open Source Mathematical Software: Building the Car Instead of
Reinventing the Wheel
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
