#5968: [with patch; needs review] increase doctest coverage of
sage/modular/modsym/modular_symbols.py from 0% to 100%
---------------------------+------------------------------------------------
Reporter: was | Owner: was
Type: defect | Status: new
Priority: major | Milestone: sage-4.0
Component: number theory | Keywords:
---------------------------+------------------------------------------------
Comment(by davidloeffler):
The new patch above adds the suggested minus sign to give a more "natural"
sort order, and adjusts the doctests accordingly; I've checked that with
this modification all doctests still pass on my machine (32-bit Linux). I
take back my comment about the {{{_repr_}}} method: all the native Python
sequence types print with spaces in, so I agree that a space in modular
symbols is better for consistency, and it certainly looks nicer.
In the process of fixing this I realised that the file
{{{modular_symbols.py}}} isn't included in the reference manual, so the
new patch does that too (and includes some ReST syntax fixes, so the
manual page builds correctly and looks nice-ish).
William: I'm happy with your changes, so if you're happy with my
subsequent ones, I guess we can call this a positive review.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/5968#comment:4>
Sage <http://sagemath.org/>
Sage - Open Source Mathematical Software: Building the Car Instead of
Reinventing the Wheel
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
