#13394: Write a WeakValueDictionary with safer key removal
-------------------------------------+-------------------------------------
Reporter: nbruin | Owner: rlm
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-5.13
Component: memleak | Resolution:
Keywords: | Merged in:
Authors: Simon King | Reviewers:
Report Upstream: None of the above | Work issues:
- read trac for reasoning. | Commit:
Branch: | e4adaebf2bd8a219f05b28746210cc0b0d0bba88
u/SimonKing/ticket/13394 | Stopgaps:
Dependencies: |
-------------------------------------+-------------------------------------
Comment (by SimonKing):
Replying to [comment:34 nbruin]:
> I don't think the entire crash report is so insightful, but the error
that causes the real problem is:
> {{{
> TypeError: Cannot create a consistent method resolution
> order (MRO) for bases VectorSpaces.element_class,
CommutativeAdditiveGroups.element_class,
CommutativeAdditiveGroups.element_class
> }}}
Hmm. How can this be related with weak value dictionaries? Sure,
categories are put in a weak dictionary (because of
`CachedRepresentation`), and join categories have an additional weak
cache. Perhaps this is why?
The disadvantage of our git workflow is: putting experimental patches on
trac wouldn't be a problem. But putting experimental commits on trac
''is'' a problem, since the experiments may show that the commit should be
changed, which means to "rewrite history" (at least for some weird notion
of history). I tend to ignore that this may constitute a problem (I
believe it is a flaw in our new workflow) and will thus put an
experimental commit in a few minutes.
--
Ticket URL: <http://trac.sagemath.org/ticket/13394#comment:35>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.