#13394: Write a WeakValueDictionary with safer key removal
-------------------------------------+-------------------------------------
Reporter: nbruin | Owner: rlm
Type: enhancement | Status: positive_review
Priority: major | Milestone: sage-6.0
Component: memleak | Resolution:
Keywords: | Merged in:
Authors: Simon King, Nils | Reviewers: Nils Bruin, Simon
Bruin | King
Report Upstream: None of the above | Work issues:
- read trac for reasoning. | Commit:
Branch: | 1a12ce6982bbe1f050e4ae627972023d5ddfa5ef
u/SimonKing/ticket/13394 | Stopgaps:
Dependencies: |
-------------------------------------+-------------------------------------
Comment (by SimonKing):
Replying to [comment:95 jdemeyer]:
> Replying to [comment:94 SimonKing]:
> > Would it be an acceptable option that I post a diff patch summarising
all the changes, and then perhaps even change the milestone back to 5.13?
> Yes.
>
> But please double-check that the Mercurial patch you post actually
matches the result of the git branch.
OK. My plan is:
- remove some trailing whitespace that I spotted and push the change (is
this needed, or would you automatically remove it when you merge it? In
this case, I'd skip that).
- `git diff master > some_file.patch`
- Edit it, so that it matches the old folder layout
- apply `some_file.patch` to a non-git version of Sage, and run tests.
- post the patch here, and Nils double checks whether the patch looks good
to him.
--
Ticket URL: <http://trac.sagemath.org/ticket/13394#comment:96>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.
