#10963: More functorial constructions
-------------------------------------+-------------------------------------
Reporter: nthiery | Owner: stumpc5
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-5.13
Component: categories | Resolution:
Keywords: | Merged in:
Authors: Nicolas M. Thiéry | Reviewers: Simon King, Frédéric
Report Upstream: N/A | Chapoton
Branch: | Work issues:
Dependencies: #11224, #8327, | Commit:
#10193, #12895, #14516, #14722, | Stopgaps:
#13589, #14471, #15069, #15094, |
#11688, #13394 |
-------------------------------------+-------------------------------------
Comment (by SimonKing):
Again, if I understand correctly, I have tested stuff with these three
patches from here applied (after moving it to git). My git log starting
with the master branch is this:
{{{
* 660f126 - (HEAD, ticket/10963) Merge branch 'ticket/13394' into
ticket/10963, because one commit has been added there (vor 4 Tagen) <Simon
King>
|\
| * 11bd210 - Remove some trailing whitespace (vor 4 Tagen) <Simon King>
* | d0ffcfa - Trac #10963: More functorial constructions (fix graded
modules with basis) (vor 4 Tagen) <Nicolas M. Thiery>
* | 1d8f75a - Trac #10963: doctests corrections (vor 4 Tagen) <Frederic
Chapoton>
* | b700f98 - Trac #10963: More functorial constructions (vor 4 Tagen)
<Nicolas M. Thiery>
|/
* 1a12ce6 - Fix some typos. Better tests for WeakValueDict iteration
guard. (vor 5 Tagen) <Simon King>
* e60890e - Add direct and indirect stresstests for the weak value
callbacks (vor 6 Tagen) <Simon King>
* 851cc95 - Avoid some pointer casts in WeakValueDict callbacks (vor 6
Tagen) <Simon King>
* 246518f - Use <dict>'s internals in WeakValueDictionary and do not
reinvent the bucket. (vor 6 Tagen) <Simon King>
* fab0ed4 - Use WeakValueDict's iteration guard more consequently (vor 7
Tagen) <Simon King>
* e4adaeb - Implement copy and deepcopy for WeakValueDictionary (vor 8
Tagen) <Simon King>
* 70a7b8a - Guard WeakValueDictionary against deletions during iteration
(vor 8 Tagen) <Simon King>
* c3dba98 - Replace weakref.WeakValueDictionary by
sage.misc.weak_dict.WeakValueDictionary (vor 9 Tagen) <Simon King>
* 17b0236 - Documentation for WeakValueDictionary (vor 9 Tagen) <Simon
King>
* f0ed60f - Initial version of a safer and faster WeakValueDictionary (vor
9 Tagen) <Simon King>
* 0d00bf7 - (trac/master, origin/master, origin/HEAD, master) Merge
branch 'build_system' (vor 4 Wochen) <R. Andrew Ohana>
}}}
So, if the "graded module" patch did not change since 4 days, then I did
successfully test it ("make ptest"). Also, the changes seem reasonable to
me.
Jeroen, would this be good enough (from your perspective) to put it back
to positive review? I can not reproduce the memory problems you mentioned.
--
Ticket URL: <http://trac.sagemath.org/ticket/10963#comment:158>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.
