#14219: rational preperiodic points for projective morphisms
--------------------------------------+----------------------------
Reporter: bhutz | Owner: bhutz
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-5.13
Component: algebraic geometry | Resolution:
Keywords: dynamics | Merged in:
Authors: Ben Hutz | Reviewers:
Report Upstream: N/A | Work issues:
Branch: | Commit:
Dependencies: #14218 | Stopgaps:
--------------------------------------+----------------------------
Comment (by vdelecroix):
Hi there,
Some quick comments (I am not the person designed to review the
mathematics in there):
- the patch does not apply on sage-5.13.beta2
- there are many trailing whitescaces that need to be removed
- the indentation must be 4 spaces wide (it is 3 in many places)
- sage convention is that `WikiNameConvention` is reserved to classes and
it would be better to not use it as variables names (I think this is too
much pain to change it right now)
- in the examples one should use "a = bla()" instead of "a=bla()"
We also discussed a very specific issue in the code (line 2588 to 2601).
The [attachment:trac_14219-optimize_root_order_computation.patch] proposes
a much direct version with, as a consequence, a little bit of speedup.
--
Ticket URL: <http://trac.sagemath.org/ticket/14219#comment:14>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.
