#14219: rational preperiodic points for projective morphisms
-----------------------------------------+---------------------------------
Reporter: bhutz | Owner: bhutz
Type: enhancement | Status: needs_work
Priority: major | Milestone: sage-5.13
Component: algebraic geometry | Resolution:
Keywords: dynamics, sage-days55 | Merged in:
Authors: Ben Hutz | Reviewers: Vincent Delecroix
Report Upstream: N/A | Work issues:
Branch: | Commit:
Dependencies: #14218 | Stopgaps:
-----------------------------------------+---------------------------------
Comment (by atowsley):
Here are a few more comments:
1) Please remove debugging code from lines 1865-1968.
2) It would be helpful to have some more comments to the code for the
Henzel lifting to make it easier to read.
3) Use is_endomorphism() where possible. Lines 2044, 2138, and 2199.
4) I think it would be clearer if the rational_preimages and
all_rational_preimages were written in that order. That is the reverse of
how they appear now.
5) Line 2145 the set 'preperiodic' as the name is misleading. Maybe
'all_preimages' would be better?
6) More comments on the Groebner basis code would be nice.
7) You should consider caching the functions rational_preperiodic_points
and rational_periodic_points.
--
Ticket URL: <http://trac.sagemath.org/ticket/14219#comment:21>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.
