#14912: UniqueRepresentation tutorial could use more love
--------------------------------------------+------------------------------
       Reporter:  darij                     |        Owner:
           Type:  defect                    |       Status:  needs_review
       Priority:  major                     |    Milestone:  sage-5.13
      Component:  documentation             |   Resolution:
       Keywords:  documentation, structure  |    Merged in:
        Authors:  Simon King                |    Reviewers:  Darij Grinberg
Report Upstream:  N/A                       |  Work issues:
         Branch:                            |       Commit:
   Dependencies:                            |     Stopgaps:
--------------------------------------------+------------------------------

Comment (by SimonKing):

 Hi Darij,

 the review patch looks fine. Disclaimer: I did not test whether the
 documentation builds fine after the changes introduced by the review
 patch. IIRC, it ''did'' build (and look) fine with my patch.

 Replying to [comment:24 darij]:
 > Thanks to Travis's insistence and also his help, I've more or less
 reviewed this one at last. The only part I wasn't able to understand is:
 > {{{
 > .. NOTE::
 >
 >     For technical reasons, it is needed that ``__classcall__``
 respectively
 >     ``__classcall_private__`` are "static methods", i.e., they are
 callable
 >     objects that do not bind to an instance or class. For example, a
 >     :class:`~sage.misc.cachefunc.cached_function` can be used here,
 because it
 >     is callable, but does not bind to an instance or class, because it
 has no
 >     ``__get__()`` method. A usual Python function, however, has a
 >     ``__get__()`` method and would thus under normal circumstances bind
 to an
 >     instance or class, and thus the instance or class would be passed to
 the
 >     function as the first argument. To prevent a callable object from
 being
 >     bound to the instance or class, one can prepend the
 ``@staticmethod``
 >     decorator to the definition; see :class:`staticmethod`.
 > }}}
 > Well, maybe it's just that I have no idea what `__get__` methods do.

 OK. Then one should add a pointer to the Python references. Travis, Do you
 have an idea what page to point to?

--
Ticket URL: <http://trac.sagemath.org/ticket/14912#comment:26>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.

Reply via email to