#15337: Speed up ulp() method of real_mpfr.pyx
------------------------------------+-------------------------------
       Reporter:  jdemeyer          |        Owner:
           Type:  enhancement       |       Status:  positive_review
       Priority:  minor             |    Milestone:  sage-5.13
      Component:  basic arithmetic  |   Resolution:
       Keywords:                    |    Merged in:
        Authors:  Jeroen Demeyer    |    Reviewers:  Paul Zimmermann
Report Upstream:  N/A               |  Work issues:
         Branch:                    |       Commit:
   Dependencies:                    |     Stopgaps:
------------------------------------+-------------------------------
Changes (by zimmerma):

 * status:  needs_review => positive_review
 * reviewer:   => Paul Zimmermann


Comment:

 I retract part of my comment [comment:17] since it works correctly with
 the patch:
 {{{
 sage: a=RDF(0)
 sage: a, a.ulp()
 (0.0, 4.94065645841e-324)
 sage: b=a.ulp()
 sage: b, b.ulp()
 (4.94065645841e-324, 4.94065645841e-324)
 }}}
 and with RR:
 {{{
 sage: a=RR(0)
 sage: a, a.ulp()
 (0.000000000000000, 8.50969131174084e-1388255822130839284)
 sage: b=a.ulp()
 sage: b, b.ulp()
 (8.50969131174084e-1388255822130839284,
 8.50969131174084e-1388255822130839284)
 }}}

 Thus the only remaining issue is whether we return self or a new object.
 Since this is a minor issue, I give a positive review.

 Paul

--
Ticket URL: <http://trac.sagemath.org/ticket/15337#comment:18>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.

Reply via email to